Proper Transaction type for eth_* calls when running Optimism
#8157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `OptimismTransactionForRpc` to `DepositTransactionForRpc` - Do not map everything to `DepositTransactionForRpc` - Remove `new` methods on `IOptimismEthRpcModule`
- Remove unused `using`s
- Only for `Deposit` transactions - Remove intermediate `ToArray`
emlautarom1
commented
Feb 3, 2025
| { | ||
| OptimismTxReceipt? receipt = _receiptFinder | ||
| .Get(block) | ||
| .Cast<OptimismTxReceipt>() |
There was a problem hiding this comment.
Are all receipts always of type OptimismTxReceipt or is it possible to have a TxReceipt? If the later is correct then this cast will fail at runtime.
LukaszRozmej
reviewed
Feb 4, 2025
LukaszRozmej
reviewed
Feb 4, 2025
- Remove duplication - Rollback virtual modifiers - Log on `Success` and `Trace` only
- Same behavior as base class
- Same behavior as base class
…pe' into fix/optimism-eth-rpc-module-txtype
I've removed the duplication in the |
deffrian
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
typeinstead of always using0x7E("deposit")Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Added unit tests to ensure that we're not changing
TxTypeand we're including additional receipt information for "deposit" transactions only.Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
I'm curious as to why we didn't get this reported earlier considering that the issue has been present since #7483.